Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example and tutorial to explain how to create custom metrics for Prometheus #914

Merged

Conversation

Yicheng-Lu-llll
Copy link
Contributor

@Yicheng-Lu-llll Yicheng-Lu-llll commented Feb 18, 2023

Why are these changes needed?

Add an example and tutorial to explain how to create custom metrics for Prometheus.

Related issue number

Closes #907

Checks

Using Step 9 to improve:
Run./install/prometheus/install.shwithout installing KubeRay operator and RayCluster:
In 5 minutes:
f4d8d9a8b9f8c37bd5f70979901398c
After 5 minutes:
67d282e3ea76009429773c840fbf05d

After installing KubeRay operator and RayCluster:
cb6d8db4ff224302b7ae6d01537a044

79592c42616d21363cfebca6bc0d379

@kevin85421 kevin85421 self-requested a review February 19, 2023 17:22
config/prometheus/rules/prometheusRules.yaml Show resolved Hide resolved
config/prometheus/rules/prometheusRules.yaml Show resolved Hide resolved
docs/guidance/prometheus-grafana.md Outdated Show resolved Hide resolved
docs/guidance/prometheus-grafana.md Show resolved Hide resolved
docs/guidance/prometheus-grafana.md Outdated Show resolved Hide resolved
docs/guidance/prometheus-grafana.md Outdated Show resolved Hide resolved
docs/guidance/prometheus-grafana.md Outdated Show resolved Hide resolved
docs/guidance/prometheus-grafana.md Show resolved Hide resolved
docs/guidance/prometheus-grafana.md Outdated Show resolved Hide resolved
docs/guidance/prometheus-grafana.md Outdated Show resolved Hide resolved
@Yicheng-Lu-llll Yicheng-Lu-llll marked this pull request as ready for review February 22, 2023 03:30
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevin85421 kevin85421 merged commit d93c3c9 into ray-project:master Feb 23, 2023
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
…Prometheus (ray-project#914)

Add an example and tutorial to explain how to create custom metrics for Prometheus.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add an example and tutorial to explain how to create custom metrics for Prometheus
2 participants