Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][Buildkite] An example test for Buildkite #919

Merged
merged 2 commits into from
Feb 28, 2023
Merged

[CI][Buildkite] An example test for Buildkite #919

merged 2 commits into from
Feb 28, 2023

Conversation

kevin85421
Copy link
Member

Why are these changes needed?

The Buildkite infrastructure for KubeRay CI is ready (Thanks @krfricke!). This PR is used to test the infrastructure after it is merged.

Related issue number

#695

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(
docker run -it golang:1.17

# Execute the following commands in the container.
git clone https://github.com/ray-project/kuberay.git
cd kuberay/ray-operator
make test

@kevin85421 kevin85421 changed the title [CI][Buildkite]An example test for Buildkite [CI][Buildkite] An example test for Buildkite Feb 21, 2023
@architkulkarni
Copy link
Contributor

Nice, should I be able to see the test somewhere here?
Screenshot 2023-02-21 at 3 42 32 PM

kevin85421
kevin85421 commented Feb 23, 2023
View reviewed changes
.buildkite/example.yml Outdated Show resolved Hide resolved
@kevin85421 kevin85421 marked this pull request as ready for review February 28, 2023 02:15
krfricke
krfricke approved these changes Feb 28, 2023
View reviewed changes
Copy link

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the directory should be /workdir/ray-operator.

Let's merge this and I'm happy to kick off a test run

.buildkite/example.yml Outdated Show resolved Hide resolved
@kevin85421
Update .buildkite/example.yml
6af66db 
Signed-off-by: Kai-Hsun Chen <[email protected]>
@kevin85421
Copy link
Member Author

Thanks, @krfricke! I will merge it after CI finishes.

@kevin85421 kevin85421 merged commit f82e7ea into ray-project:master Feb 28, 2023
@kevin85421 kevin85421 mentioned this pull request Mar 13, 2023
Merged
4 tasks
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
@kevin85421
[CI][Buildkite] An example test for Buildkite (ray-project#919)
7028fd1 
The Buildkite infrastructure for KubeRay CI is ready. This PR is used to test the infrastructure after it is merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krfricke krfricke krfricke approved these changes

@architkulkarni architkulkarni Awaiting requested review from architkulkarni

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevin85421 @architkulkarni @krfricke