-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add core API and backend service design doc #98
Add core API and backend service design doc #98
Conversation
|
||
// ImageTemplate can be used by worker group and workspce. | ||
// They can be distinguish by different entrypoints | ||
message ImageTemplate { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think ray-operator should not be aware of the imageTemplate. it just need image
to build the cluster. ImageTemplate
corresponding services can be used to build images separately.
- User who does not have docker experience can build images using this service.
- User can query the image result built by the service
- User can use that image result to build ray cluster.
/cc @akanso please have a check |
The functionality of exposing a simpler interface to the users other than the K8s interface is very valuable to none K8s users. It is not clear from the design Doc if the operator code itself is extended to support this feature? I think an alternative design, is to run the GPRC server as an independent container (e.g. side-car container), that is capable of processing the GRPC requests and create RayCluster Custom Resources that the Ray Operator can read and process. client --> GRPC Server --> [created Custom Resources] <-- Ray Operator (reads CR and accordingly performs CRUD ) |
I see. I think the gap is I talked too much api etc instead of operator interactions and deployment topology in the doc.
exactly. It would be a separate pod and the path is like what you described. Let me add a section for it |
12b2ff0
to
3128084
Compare
@akanso I add a short summary to talk about deployment and interactions. |
Ali reviewed the docs and overall looks good to him as well. We can merge the PR. |
* Add core API and backend service design doc * Address feedbacks * Fix typos
Why are these changes needed?
Per Ali's request in #93, It's better to write a one page summary about the proposed change and get it approved before any implementation.
Related issue number
#53 #54
/cc @akanso @chenk008 @caitengwei @chaomengyuan
Checks