[Feature] Add python client test to action #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin85421
reviewed
Mar 28, 2023
| - name: Set up Docker | ||
| uses: docker-practice/actions-setup-docker@master | ||
|
|
||
| - name: Install Kind |
There was a problem hiding this comment.
Would you mind sharing more details about why we need to create a k8s cluster here? Thanks!
There was a problem hiding this comment.
Though currently, the test does not interact with the k8s cluster, the init function in kuberay_cluster_api will load kube config, which will report errors if there is no k8s server. I also added the above explanation in the description above.
|
The CI failure is not related to this PR. |
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
Add python client test to action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Testing python client library in CI.
Why create a k8s cluster in the test?
Though currently, the test does not interact with the k8s cluster, the init function in kuberay_cluster_api will load kube config, which will report errors if there is no k8s server.
Related issue number
Checks