Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubernetes dependency in python client library #998

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

jasoonn
Copy link
Contributor

@jasoonn jasoonn commented Mar 30, 2023

Why are these changes needed?

The kuberay python-client library uses Kubernetes Python Client. Hence, it is necessary to make Kubernetes Python Client be the prerequisite when installing kuberay python-client library.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevin85421 kevin85421 merged commit 25d5568 into ray-project:master Apr 4, 2023
kevin85421 pushed a commit to kevin85421/kuberay that referenced this pull request Apr 4, 2023
Add kubernetes dependency in python client library
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Add kubernetes dependency in python client library
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants