Skip to content

Commit

Permalink
[core][telemetry] ray.get timeout=0 telemetry tracking (#31159)
Browse files Browse the repository at this point in the history
This is to gauge the usage of ray.get(timeout=0) which will have a different behaviour in future ray versions, as per #28465
  • Loading branch information
rickyyx authored and AmeerHajAli committed Jan 12, 2023
1 parent 3e85fb8 commit 076ec36
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
5 changes: 5 additions & 0 deletions python/ray/_private/worker.py
Original file line number Diff line number Diff line change
Expand Up @@ -2313,6 +2313,11 @@ def get(
UserWarning,
)

# Record this usage in telemetry
import ray._private.usage.usage_lib as usage_lib

usage_lib.record_extra_usage_tag(usage_lib.TagKey.RAY_GET_TIMEOUT_ZERO, "True")

worker = global_worker
worker.check_connected()

Expand Down
4 changes: 4 additions & 0 deletions src/ray/protobuf/usage.proto
Original file line number Diff line number Diff line change
Expand Up @@ -85,4 +85,8 @@ enum TagKey {
// The count(int) of worker crash with exit type 'out-of-memory' since
// the cluster started, emitted from GCS
WORKER_CRASH_OOM = 303;
// If {true, false} setting of timeout =0 in `ray.get``, i.e. ray.get(..., timeout=0)
// This is to track usage of the buggy behavior that will be fixed.
// See https://github.com/ray-project/ray/issues/28465 for more details.
RAY_GET_TIMEOUT_ZERO = 304;
}

0 comments on commit 076ec36

Please sign in to comment.