Only delete conda on minimal install

Signed-off-by: Kai Fricke <[email protected]>
ray-project · Sep 18, 2022 · 1aad104 · 1aad104
1 parent 762b841
commit 1aad104
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/ci/docker/Dockerfile.ml b/ci/docker/Dockerfile.ml
@@ -15,4 +15,4 @@ COPY . .
 # Install Ray
 RUN SKIP_BAZEL_BUILD=1 RAY_INSTALL_JAVA=0 bash --login -i -c -- "python3 -m pip install -e /ray/python/"
 
-RUN RLLIB_TESTING=1 TRAIN_TESTING=1 TUNE_TESTING=1 ./ci/env/install-dependencies.sh
+RUN RLLIB_TESTING=1 TRAIN_TESTING=1 TUNE_TESTING=1 bash --login -i ./ci/env/install-dependencies.sh
diff --git a/ci/docker/Dockerfile.test b/ci/docker/Dockerfile.test
@@ -15,4 +15,4 @@ COPY . .
 # Install Ray
 RUN SKIP_BAZEL_BUILD=1 RAY_INSTALL_JAVA=0 bash --login -i -c -- "python3 -m pip install -e /ray/python/"
 
-RUN ./ci/env/install-dependencies.sh
+RUN bash --login -i ./ci/env/install-dependencies.sh
diff --git a/ci/env/install-dependencies.sh b/ci/env/install-dependencies.sh
@@ -115,7 +115,9 @@ install_miniconda() {
         conda="${miniconda_dir}\Scripts\conda.exe"
         ;;
       *)
-        rm -rf "${miniconda_dir}"
+        if [ "${MINIMAL_INSTALL-}" = 1 ]; then
+          rm -rf "${miniconda_dir}"
+        fi
         mkdir -p -- "${miniconda_dir}"
         # We're forced to pass -b for non-interactive mode.
         # Unfortunately it inhibits PATH modifications as a side effect.