Skip to content

Commit

Permalink
[Serve] Fix serve run help message (#37859) (#38018)
Browse files Browse the repository at this point in the history
Re: #35754 We previously added `-h` help command to the serve cli's click group. This caused the autogenerated help message to take `-h` as the default help command. For `serve run` we have a collusion on `-h` as it's used for host option as well. This PR changed the order of the click help option so the `--help` will be used in autogenerated help messages.

Signed-off-by: Edward Oakes <[email protected]>
Co-authored-by: Gene Der Su <[email protected]>
  • Loading branch information
edoakes and GeneDer authored Aug 8, 2023
1 parent 1945d8f commit 4d31114
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion python/ray/serve/scripts.py
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ def convert_args_to_dict(args: Tuple[str]) -> Dict[str, str]:

@click.group(
help="CLI for managing Serve applications on a Ray cluster.",
context_settings=dict(help_option_names=["-h", "--help"]),
context_settings=dict(help_option_names=["--help", "-h"]),
)
def cli():
pass
Expand Down

0 comments on commit 4d31114

Please sign in to comment.