Skip to content

Commit

Permalink
[data] removing unneeded test case (#48031)
Browse files Browse the repository at this point in the history
## Why are these changes needed?
This is a redundant test case with the following two asserts that broke
things upstream. This PR removes this assert.

## Related issue number

## Checks

- [x] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [x] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [x] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [x] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: Matthew Owen <[email protected]>
  • Loading branch information
omatthew98 authored Oct 16, 2024
1 parent 35d95a7 commit f80434e
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion python/ray/data/tests/test_logging.py
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,6 @@ def test_json_logging_configuration(

# Ensure handlers correctly setup
handlers = logger.handlers
assert len(handlers) == 2
assert sum(handler.name == "file_json" for handler in handlers) == 1
assert sum(handler.name == "console" for handler in handlers) == 1

Expand Down

0 comments on commit f80434e

Please sign in to comment.