Skip to content

Commit

Permalink
Gce tests (#33507)
Browse files Browse the repository at this point in the history
* Fix 'Observed wheel commit () is not expected' issue (#32156) that has been creeping through many of ci/cd builds in our pipeline.

The existing code uses pipe to read from a rather large file (>50MB). Pipe however has buffer limit which by default in term of kb (https://man7.org/linux/man-pages/man7/pipe.7.html) so what we look for might not exist. We can fix this by tell unzip the exact file we are looking for. That file is pretty small so we should not hit buffer limit.

You might notice other surpises might still happen with this fix (e.g. many files that match ^__commit__). This sanity check goes back to 2 years ago by our veteran Kai (234b015) to sanity check issues with stale artifacts from previous builds or race conditions between builds. Further investigation on how builkite agent multi-tenant is setup might or might not simplify this logic further.

Signed-off-by: Cuong Nguyen <[email protected]>

* Improve wheel commit validation error message

Signed-off-by: Cuong Nguyen <[email protected]>

* Add a sample GCE test

Signed-off-by: Cuong Nguyen <[email protected]>

* Disable TEST_ATTR_REGEX_FILTERS for testing

Signed-off-by: Cuong Nguyen <[email protected]>

* Make tests running on staging v2

Signed-off-by: Cuong Nguyen <[email protected]>

* Fix compute configs

Signed-off-by: Cuong Nguyen <[email protected]>

* Use n2-standard-8 machines

Signed-off-by: Cuong Nguyen <[email protected]>

---------

Signed-off-by: Cuong Nguyen <[email protected]>
Signed-off-by: Cuong Nguyen <[email protected]>
  • Loading branch information
can-anyscale authored Mar 21, 2023
1 parent 5e579a6 commit fb95798
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit fb95798

Please sign in to comment.