Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Placement Group] Support RayPlacementGroupError #10508

Closed
rkooo567 opened this issue Sep 2, 2020 · 5 comments
Closed

[Placement Group] Support RayPlacementGroupError #10508

rkooo567 opened this issue Sep 2, 2020 · 5 comments
Assignees
@oliverhu
Labels
enhancement Request for new feature and/or capability P2 Important issue, but not time-critical
Milestone
Placement Group API

Comments

@rkooo567
Copy link
Contributor

rkooo567 commented Sep 2, 2020

Describe your feature request

When tasks are failed due to placement group removal, we should raise RayPlacementGroupError instead of worker dead error or actor dead error.
@rkooo567 rkooo567 added enhancement Request for new feature and/or capability P2 Important issue, but not time-critical labels Sep 2, 2020
@rkooo567 rkooo567 added this to the Placement Group API milestone Sep 2, 2020
@rkooo567 rkooo567 self-assigned this Sep 4, 2020
@rkooo567 rkooo567 added the good first issue Great starter issue for someone just starting to contribute to Ray label Sep 29, 2020
@chamorajg
Copy link

Can I work on this issue ?

@rkooo567
Copy link
Contributor Author

@chandramoulirajagopalan Contribution is always welcomed :). But please describe your high-level implementation plan beforehand!

@chamorajg
Copy link

My plan of action would be
1.) Reproduce the error.
2.) Find the source code where the Worker dead error or actor dead error has been raised rather than RayPlacementGroupError.
3.) Fix the source code and then commit.

@chamorajg
Copy link

chamorajg commented Oct 11, 2020 •
edited
Loading

Do we have any code to reproduce this error? @rkooo567

@rkooo567 rkooo567 removed the good first issue Great starter issue for someone just starting to contribute to Ray label Dec 2, 2020
@oliverhu oliverhu self-assigned this Dec 12, 2020
@oliverhu oliverhu mentioned this issue Dec 12, 2020
Closed
6 tasks
@rkooo567 rkooo567 removed their assignment Dec 13, 2020
oliverhu added a commit to oliverhu/ray that referenced this issue Dec 31, 2020
@oliverhu
[Placement Group] Support RayPlacementGroupError ray-project#10508
81c3a2c
@oliverhu oliverhu mentioned this issue Dec 31, 2020
Closed
6 tasks
@rkooo567 rkooo567 mentioned this issue Jan 15, 2021
Closed
6 tasks
@rkooo567
Copy link
Contributor Author

rkooo567 commented Nov 2, 2021

Duplicate #10232

@rkooo567 rkooo567 closed this as completed Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverhu oliverhu

Labels
enhancement Request for new feature and/or capability P2 Important issue, but not time-critical
Projects
None yet
Milestone
Placement Group API
3 participants
@oliverhu @rkooo567 @chamorajg