Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tune] Ray Tune Checkpoint Warning with PL Checkpoint Callbacks #29340

Closed
yinweisu opened this issue Oct 13, 2022 · 6 comments
Closed

[Tune] Ray Tune Checkpoint Warning with PL Checkpoint Callbacks #29340

yinweisu opened this issue Oct 13, 2022 · 6 comments
Assignees
Labels
bug Something that is supposed to be working; but isn't P2 Important issue, but not time-critical tune Tune-related issues

Comments

@yinweisu
Copy link

What happened + What you expected to happen

I got the following warning when using PL Ray Tune checkpoint callback:

/home/ubuntu/anaconda3/envs/test_multimodal/lib/python3.8/site-packages/ray/tune/trainable/function_trainable.py:642: DeprecationWarning: `checkpoint_dir` in `func(config, checkpoint_dir)` is being deprecated. To save and load checkpoint in trainable functions, please use the `ray.air.session` API:

from ray.air import session

def train(config):
    # ...
    session.report({"metric": metric}, checkpoint=checkpoint)

For more information please see https://docs.ray.io/en/master/ray-air/key-concepts.html#session

Versions / Dependencies

Ray 2.0
Ubuntu

Reproduction script

Just the official example:
https://docs.ray.io/en/latest/tune/examples/tune-pytorch-lightning.html#

Issue Severity

Medium: It is a significant difficulty but I can work around it.

@yinweisu yinweisu added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Oct 13, 2022
@xwjiang2010 xwjiang2010 added the tune Tune-related issues label Nov 4, 2022
@hora-anyscale
Copy link
Contributor

Per Triage Sync: @Yard1 - please review

@Yard1 Yard1 added P2 Important issue, but not time-critical and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Nov 5, 2022
@richardliaw
Copy link
Contributor

@Yard1 could you follow up here?

@movy
Copy link

movy commented Jan 26, 2023

Same here, still not sure what this error wants me to do.

@Yard1
Copy link
Member

Yard1 commented Jan 26, 2023

This will be removed when we fully deprecate tune.report in a future release. This message can be safely ignored.

@yinweisu
Copy link
Author

This still present for ray 2.4
I wonder is there a way to suppress the warning? I tried to set the logging level to logging.ERROR but still printing the warning

@anyscalesam anyscalesam removed the air label Oct 28, 2023
@justinvyu
Copy link
Contributor

tune.report is hard-deprecated in 2.7. See migration guide: https://docs.google.com/document/d/1J-09US8cXc-tpl2A1BpOrlHLTEDMdIJp6Ah1ifBUw7Y/edit#heading=h.xi4qh6ve48tm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't P2 Important issue, but not time-critical tune Tune-related issues
Projects
None yet
Development

No branches or pull requests

8 participants