Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Datasets] Add from_torch #29588

Merged
merged 12 commits into from
Nov 7, 2022
Merged

[Datasets] Add from_torch #29588

merged 12 commits into from
Nov 7, 2022

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Oct 23, 2022 •
edited
Loading

Signed-off-by: Balaji [email protected]

Why are these changes needed?

We added from_huggingface, and SimpleTorchDatasource is clunky. For more motivation, read #29340.

Related issue number

Towards #29430

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

clarkzinzow
clarkzinzow approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@clarkzinzow clarkzinzow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@richardliaw richardliaw merged commit aff0c91 into ray-project:master Nov 7, 2022
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
@bveeramani @clarkzinzow @WeichenXu123
[Datasets] Add from_torch (ray-project#29588)
99488f7 
Co-authored-by: Clark Zinzow <[email protected]>
Signed-off-by: Weichen Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarkzinzow clarkzinzow clarkzinzow approved these changes

@richardliaw richardliaw richardliaw approved these changes

@ericl ericl Awaiting requested review from ericl

@scv119 scv119 Awaiting requested review from scv119

@jjyao jjyao Awaiting requested review from jjyao

@jianoaix jianoaix Awaiting requested review from jianoaix

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

@c21 c21 Awaiting requested review from c21

Assignees

@clarkzinzow clarkzinzow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bveeramani @richardliaw @clarkzinzow