Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][python3.11] Wheel build #31362

Closed
rickyyx opened this issue Dec 29, 2022 · 7 comments · Fixed by #36681
Closed

[ci][python3.11] Wheel build #31362

rickyyx opened this issue Dec 29, 2022 · 7 comments · Fixed by #36681
Assignees
Labels
core Issues that should be addressed in Ray Core P1 Issue that should be fixed within a few weeks Ray 2.6

Comments

@rickyyx
Copy link
Contributor

rickyyx commented Dec 29, 2022

What happened + What you expected to happen

Mac and Windows wheels for python3.11 are not supported yet:

  • Mac: CI machines don't have python 3.11 installed
  • Windows: Conda channels not supported.

Versions / Dependencies

master

Reproduction script

NA

Issue Severity

None

@rickyyx
Copy link
Contributor Author

rickyyx commented Apr 23, 2023

Looks like conda (which ray depends on for wheel building process) will be officially supportinh 3.11 in its up coming release. Will try to make ray work on 3.11 for non-linux once the conda release is out.

conda/conda#11170 (comment)

@ddelange
Copy link
Contributor

just out of curiosity and willingness to help:

  • is there a particular reason to use conda to build wheels?
  • could you point me to the code?
  • i set up a build with cibuildwheel before, did you also consider it? (it's from the python packaging authority and builds PEP conform on the official manylinux images)
    • the resulting wheels will cover mostly any machine and will have the widest possible compatibility (although being built on the most recent OS versions)

@rkooo567 rkooo567 added P1 Issue that should be fixed within a few weeks core Issues that should be addressed in Ray Core Ray 2.6 labels May 15, 2023
@rickyyx
Copy link
Contributor Author

rickyyx commented May 17, 2023

just out of curiosity and willingness to help:

  • is there a particular reason to use conda to build wheels?

  • could you point me to the code?

  • i set up a build with cibuildwheel before, did you also consider it? (it's from the python packaging authority and builds PEP conform on the official manylinux images)

    • the resulting wheels will cover mostly any machine and will have the widest possible compatibility (although being built on the most recent OS versions)

I think it was more of a historical reason - I don't think it's a must-have dependency.

I believe the entry point for wheel building is here:

- label: ":ferris_wheel: Wheels and Jars"

@ddelange
Copy link
Contributor

Looks like conda (which ray depends on for wheel building process) will be officially supportinh 3.11 in its up coming release. Will try to make ray work on 3.11 for non-linux once the conda release is out.

conda/conda#11170 (comment)

@rickyyx support is released conda/conda@7ec97d6 🚀

@ddelange
Copy link
Contributor

ddelange commented Jun 8, 2023

Hi @rickyyx 👋

I saw ray 2.5.0 just landed, still without win and mac wheels. Is there manual intervention needed from your side for this ticket?

@rickyyx
Copy link
Contributor Author

rickyyx commented Jun 9, 2023

Yes, @ddelange we are looking into this now. Should be able to support both win + mac and potentially docker images from Ray for python 3.11 in 2.6.

@ddelange
Copy link
Contributor

for future reference the corresponding mac PR: #36185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues that should be addressed in Ray Core P1 Issue that should be fixed within a few weeks Ray 2.6
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants