Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci][py3.11] Build python wheels on mac os for 3.11 #36185

Merged
merged 10 commits into from
Jun 9, 2023
Merged

[ci][py3.11] Build python wheels on mac os for 3.11 #36185

merged 10 commits into from
Jun 9, 2023

Conversation

rickyyx
Copy link
Contributor

@rickyyx rickyyx commented Jun 8, 2023 •
edited
Loading

Why are these changes needed?

  • Unifying the wheel building for macos since both could be done with conda. (We are already building wheels with conda for arm64)
  • Added support for 3.11 wheels which is then trivial. (The system installed python seems to have 3.11 missing on buildkite still).

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@rickyyx
init
3b74d53 
Signed-off-by: Ricky Xu <[email protected]>
@rickyyx
update
3d1d332 
Signed-off-by: Ricky Xu <[email protected]>
@rickyyx
add arm64
418963c 
Signed-off-by: Ricky Xu <[email protected]>
@rickyyx
try
1105af4 
Signed-off-by: Ricky Xu <[email protected]>
@rickyyx
try
d9df79b 
Signed-off-by: Ricky Xu <[email protected]>
@rickyyx
update
a47d2af 
Signed-off-by: Ricky Xu <[email protected]>
@rickyyx
remove
1fa0e7a 
Signed-off-by: Ricky Xu <[email protected]>
@rickyyx
done
2e8c525 
Signed-off-by: Ricky Xu <[email protected]>
@rickyyx rickyyx changed the title Pr ci mac 3 11 2 [ci][py3.11] Build python wheels on mac os for 3.11 Jun 8, 2023
rickyyx
rickyyx commented Jun 8, 2023
View reviewed changes
python/build-wheel-macos.sh
@@ -6,79 +6,66 @@ set -e
# Show explicitly which commands are currently running.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually moved from build-wheel-macos-arm64.sh

I think we could unify the two for building macos wheels.

@rickyyx
update
c60489c 
Signed-off-by: Ricky Xu <[email protected]>
@rickyyx
hm
0981605 
Signed-off-by: Ricky Xu <[email protected]>
@rickyyx rickyyx marked this pull request as ready for review June 9, 2023 00:20
@rickyyx
Copy link
Contributor Author

rickyyx commented Jun 9, 2023

Wheels built are here:

krfricke
krfricke approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@krfricke krfricke merged commit 3236cff into ray-project:master Jun 9, 2023
@can-anyscale
Copy link
Collaborator

I looked at this recently for docker image build and it seems that the latest miniconda does not have support for 3.11 yet. According to their website (https://docs.conda.io/en/main/miniconda.html), miniconda is still at 23.3.1; we need 23.5.0 for 3.11 support

@rickyyx
Copy link
Contributor Author

rickyyx commented Jun 10, 2023

https://docs.conda.io/en/main/miniconda.html

I think when I installed a 23.3.1 - I was able to install py3.11 env with conda install though somehow.

@rickyyx
Copy link
Contributor Author

rickyyx commented Jun 10, 2023

I looked at this recently for docker image build and it seems that the latest miniconda does not have support for 3.11 yet. According to their website (https://docs.conda.io/en/main/miniconda.html), miniconda is still at 23.3.1; we need 23.5.0 for 3.11 support

Actually, I think we are able to install 23.5.0 through CLI already. Let me add an update command just so that we are using the most recent ones.

rickyyx added a commit to rickyyx/ray that referenced this pull request Jun 13, 2023
@rickyyx
[ci][py3.11] Build python wheels on mac os for 3.11 (ray-project#36185)
6901987 
Unifying the wheel building for macos since both could be done with conda. (We are already building wheels with conda for arm64)
Added support for 3.11 wheels which is then trivial. (The system installed python seems to have 3.11 missing on buildkite still).


Signed-off-by: Ricky Xu <[email protected]>
@rickyyx rickyyx mentioned this pull request Jun 13, 2023
Merged
8 tasks
ArturNiederfahrenhorst pushed a commit that referenced this pull request Jun 13, 2023
@rickyyx
[ci][py3.11] Build python wheels on mac os for 3.11 (#36185) (#36373)
cf4efd3 
Unifying the wheel building for macos since both could be done with conda. (We are already building wheels with conda for arm64)
Added support for 3.11 wheels which is then trivial. (The system installed python seems to have 3.11 missing on buildkite still).

Signed-off-by: Ricky Xu <[email protected]>
scv119 pushed a commit that referenced this pull request Jun 13, 2023
@rickyyx
[doc][python3.11] Update mac os wheels built link (#36379)
07a5bf0 
With #36185 the wheels for 3.11 are added, and the wheel names for the specific architecture is updated.

---------

Signed-off-by: rickyyx <[email protected]>
rickyyx added a commit to rickyyx/ray that referenced this pull request Jun 13, 2023
@rickyyx
[doc][python3.11] Update mac os wheels built link (ray-project#36379)
c555f66 
With ray-project#36185 the wheels for 3.11 are added, and the wheel names for the specific architecture is updated.

---------

Signed-off-by: rickyyx <[email protected]>
This was referenced Jun 13, 2023
Merged
Merged
rickyyx added a commit that referenced this pull request Jun 14, 2023
@rickyyx
[doc][python3.11] Update mac os wheels built link (#36379) (#36388)
80e2558 
With #36185 the wheels for 3.11 are added, and the wheel names for the specific architecture is updated.

---------

Signed-off-by: rickyyx <[email protected]>
@rickyyx rickyyx mentioned this pull request Jun 16, 2023
Closed
This was referenced Jun 23, 2023
Merged
Closed
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@rickyyx @arvind-chandra
[ci][py3.11] Build python wheels on mac os for 3.11 (ray-project#36185)
a27d817 
Unifying the wheel building for macos since both could be done with conda. (We are already building wheels with conda for arm64)
Added support for 3.11 wheels which is then trivial. (The system installed python seems to have 3.11 missing on buildkite still).

Signed-off-by: Ricky Xu <[email protected]>
Signed-off-by: e428265 <[email protected]>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@rickyyx @arvind-chandra
[doc][python3.11] Update mac os wheels built link (ray-project#36379)
5f6acc6 
With ray-project#36185 the wheels for 3.11 are added, and the wheel names for the specific architecture is updated.

---------

Signed-off-by: rickyyx <[email protected]>
Signed-off-by: e428265 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krfricke krfricke krfricke approved these changes

Assignees

@krfricke krfricke

@aslonnie aslonnie

@can-anyscale can-anyscale

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rickyyx @can-anyscale @krfricke @aslonnie