Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate metrics and tracing library #3858

Closed
4 of 5 tasks
ericl opened this issue Jan 25, 2019 · 3 comments
Closed
4 of 5 tasks

Integrate metrics and tracing library #3858

ericl opened this issue Jan 25, 2019 · 3 comments
Assignees
Labels
enhancement Request for new feature and/or capability

Comments

@ericl
Copy link
Contributor

ericl commented Jan 25, 2019

OpenCensus provides a general purpose stats and tracing API with support for many backends, including Zipkin and Prometheus.

While we likely won't use all the functionality immediately, a good first step would be to add the library to the build and port existing debug counters to use the stats::Record() API.

There have been some concerns around backend compatibility (I.e., #3664). If needed, we can add a thin wrapper layer at the point of recording metrics to allow users to intercept the record calls, but ideally this can be avoided since OpenCensus provides push and pull APIs already for reading out metrics.

TODOs:

  • Integrate opencensus into building system
  • Add example metrics into raylet
  • support global tags auto added
  • Add all metrics for raylet
  • Integrate web views into our dashboard
@robertnishihara
Copy link
Collaborator

@pcmoritz has been doing a lot of work on the build system recently to switch to Bazel (see #2887), so if we add it to the build, let's do it as part of Bazel and not the old build system.

@jovany-wang
Copy link
Contributor

@micafan cc

@jovany-wang jovany-wang self-assigned this Feb 15, 2019
@ericl ericl added enhancement Request for new feature and/or capability and removed feature request labels Mar 5, 2020
@edoakes
Copy link
Contributor

edoakes commented Mar 5, 2020

Stale - please open new issue if still relevant

@edoakes edoakes closed this as completed Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request for new feature and/or capability
Projects
None yet
Development

No branches or pull requests

4 participants