Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate metric items into raylet #4602

Merged
merged 28 commits into from
Apr 25, 2019
Merged

Integrate metric items into raylet #4602

merged 28 commits into from
Apr 25, 2019

Conversation

jovany-wang
Copy link
Contributor

@jovany-wang jovany-wang commented Apr 11, 2019 •
edited
Loading

What do these changes do?

Integrate these metric items into raylet:

  • RedisLatency(Also, I refined the redis_context callback.)
  • AvailableResource
  • TotalResource
  • CurrentDriver
  • ObjectManagerStats
  • ActorStats
  • ConnectionPoolStats
  • LineageCacheStats
  • ReconstructionPolicyStats
  • SchedulingQueueStats
  • TaskDependencyManagerStats

Related issue number

#3858

Linter

  • I've run scripts/format.sh to lint the changes in this PR.

@jovany-wang jovany-wang mentioned this pull request Apr 11, 2019
Closed
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/427/
Test PASSed.

@jovany-wang jovany-wang force-pushed the integrate_metrics branch 2 times, most recently from c194cea to 647b3b6 Compare April 13, 2019 16:29
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13807/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/484/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/485/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/486/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13810/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13811/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/487/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13812/
Test FAILed.

@jovany-wang jovany-wang mentioned this pull request Apr 16, 2019
Merged
1 task
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13813/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/509/
Test PASSed.

@ray-project ray-project deleted a comment from AmplabJenkins Apr 18, 2019
@ray-project ray-project deleted a comment from AmplabJenkins Apr 18, 2019
@ray-project ray-project deleted a comment from AmplabJenkins Apr 18, 2019
@ray-project ray-project deleted a comment from AmplabJenkins Apr 18, 2019
@ray-project ray-project deleted a comment from AmplabJenkins Apr 18, 2019
@jovany-wang jovany-wang changed the title [WIP] integrate metric items into raylet Integrate metric items into raylet Apr 18, 2019
@ray-project ray-project deleted a comment from AmplabJenkins Apr 18, 2019
@ray-project ray-project deleted a comment from AmplabJenkins Apr 18, 2019
@ray-project ray-project deleted a comment from AmplabJenkins Apr 18, 2019
@ray-project ray-project deleted a comment from AmplabJenkins Apr 18, 2019
@ray-project ray-project deleted a comment from AmplabJenkins Apr 18, 2019
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13861/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/526/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13866/
Test FAILed.

@jovany-wang
Copy link
Contributor Author

jovany-wang commented Apr 22, 2019 •
edited
Loading

I have addressed all comments, any more review suggestion?

raulchen
raulchen reviewed Apr 22, 2019
View reviewed changes
src/ray/raylet/node_manager.cc Show resolved Hide resolved
src/ray/raylet/node_manager.cc Show resolved Hide resolved
src/ray/stats/metric_defs.h Outdated Show resolved Hide resolved
src/ray/stats/metric_defs.h Outdated Show resolved Hide resolved
src/ray/stats/metric_defs.h Outdated Show resolved Hide resolved
src/ray/stats/metric_defs.h Outdated Show resolved Hide resolved
src/ray/stats/metric_defs.h Outdated Show resolved Hide resolved
src/ray/raylet/node_manager.cc Outdated Show resolved Hide resolved
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/551/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13907/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/554/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13913/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/562/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13927/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/564/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13929/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-Perf-Integration-PRB/568/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/13933/
Test FAILed.

@raulchen raulchen merged commit c26f24a into ray-project:master Apr 25, 2019
@robertnishihara robertnishihara mentioned this pull request May 4, 2019
Closed
@jovany-wang jovany-wang deleted the integrate_metrics branch February 3, 2020 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulchen raulchen raulchen approved these changes

@ericl ericl Awaiting requested review from ericl

@robertnishihara robertnishihara Awaiting requested review from robertnishihara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jovany-wang @AmplabJenkins @robertnishihara @raulchen