Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release test xgboost_tune_small.aws failed #43155

Closed
can-anyscale opened this issue Feb 14, 2024 · 5 comments · Fixed by #43176
Closed

Release test xgboost_tune_small.aws failed #43155

can-anyscale opened this issue Feb 14, 2024 · 5 comments · Fixed by #43176
Assignees
@justinvyu
Labels
bug Something that is supposed to be working; but isn't jailed-test Indicate that this test is jailed and will stop running in CI/CD P0 Issues that should be fixed in short order ray-test-bot Issues managed by OSS test policy release-test release test triage Needs triage (eg: priority, bug/not-bug, and owning component) weekly-release-blocker Issues that will be blocking Ray weekly releases

Comments

@can-anyscale
Copy link
Collaborator

Release test xgboost_tune_small.aws failed. See https://buildkite.com/ray-project/release/builds/8408#018da6a4-c2a8-4382-b6c0-0c7d0a827ff2 for more details.

Managed by OSS Test Policy
@can-anyscale can-anyscale added bug Something that is supposed to be working; but isn't ml P0 Issues that should be fixed in short order ray-test-bot Issues managed by OSS test policy release-test release test triage Needs triage (eg: priority, bug/not-bug, and owning component) weekly-release-blocker Issues that will be blocking Ray weekly releases labels Feb 14, 2024
@can-anyscale can-anyscale self-assigned this Feb 14, 2024
@can-anyscale
Copy link
Collaborator Author

Blamed commit: eb8950b found by bisect job https://buildkite.com/ray-project/release-tests-bisect/builds/869

@justinvyu
Copy link
Contributor

justinvyu commented Feb 14, 2024 •
edited
Loading

@can-anyscale I specify the xgboost_ray / lightgbm_ray dependencies in ml/core-requirements.txt:

ray/python/requirements/ml/core-requirements.txt

Line 8 in c812e31

git+https://github.com/ray-project/xgboost_ray.git

Is that enough for these packages to be included in the release test BYOD?

This test includes a post build script that reinstalls the package -- is this not necessary?

ray/release/ray_release/byod/byod_xgboost_test.sh

Line 7 in c812e31

pip3 install -U --force-reinstall --no-deps xgboost_ray lightgbm_ray

@justinvyu
Copy link
Contributor

Trying to remove it here: #43176

@justinvyu justinvyu mentioned this issue Feb 14, 2024
Merged
8 tasks
@can-anyscale
Copy link
Collaborator Author

Test has been failing for far too long. Jailing.

@can-anyscale can-anyscale added the jailed-test Indicate that this test is jailed and will stop running in CI/CD label Feb 16, 2024
@can-anyscale
Copy link
Collaborator Author

Test passed on latest run: https://buildkite.com/ray-project/release/builds/8839#018dc04c-5f6b-43c1-aa80-926374e8bd5f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinvyu justinvyu

Labels
bug Something that is supposed to be working; but isn't jailed-test Indicate that this test is jailed and will stop running in CI/CD P0 Issues that should be fixed in short order ray-test-bot Issues managed by OSS test policy release-test release test triage Needs triage (eg: priority, bug/not-bug, and owning component) weekly-release-blocker Issues that will be blocking Ray weekly releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ci][train] Remove unnecessary xgboost_ray/lightgbm_ray reinstalls for release tests justinvyu/ray
2 participants
@justinvyu @can-anyscale