-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci][train] Remove unnecessary xgboost_ray
/lightgbm_ray
reinstalls for release tests
#43176
[ci][train] Remove unnecessary xgboost_ray
/lightgbm_ray
reinstalls for release tests
#43176
Conversation
Signed-off-by: Justin Yu <[email protected]>
xgboost_ray
/lightgbm_ray
reinstalls for release tests
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
…ost_release_tests
…in tune session) -> use cluster storage in dist cluster Signed-off-by: Justin Yu <[email protected]>
…ost_release_tests
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
@aslonnie Addressed your comment. Could I get another review / approval? This is to fix broken release tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this also works.
I thought you wanted to update the deps in ml/core-requirements
I'm not going to spend time to figure it out since I am trying to remove this dependency within a week. |
Why are these changes needed?
#42111 removed classes that were depended on by the latest release of
xgboost_ray
. The master branch of this external library has some changes that remove this dependency, which was updated inml/core-requirements.txt
.However, post build scripts for release tests install the latest version of these libraries, causing all these release test failures. We should test with the master version of the external libraries. This is a temporary measure, since we are planning to remove
xgboost_ray
andlightgbm_ray
dependencies from Ray for 2.10 (to finish within 2 weeks).Related issue number
Closes #43155
Closes #43161
Closes #43163
Closes #43156
Closes #43157
Closes #43158
Closes #43159
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.