Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Ray Data progress bars left partially completed after execution completes on Jupyter notebook #44983

Closed
scottjlee opened this issue Apr 26, 2024 · 1 comment · Fixed by #46289
Assignees
Labels
bug Something that is supposed to be working; but isn't data Ray Data-related issues P1 Issue that should be fixed within a few weeks

Comments

@scottjlee
Copy link
Contributor

scottjlee commented Apr 26, 2024

What happened + What you expected to happen

When executing a Ray Dataset on Jupyter notebook, the progress bar is left partially complete after the dataset finishes executing:
Screenshot at Apr 25 17-44-03

When we disable ray_tqdm, the progress bars are filled to completion as expected:
Screenshot at Apr 25 17-34-29

So it looks like there is likely a bug in ray_tqdm where we are not updating the progress bar before closing it.

We should also update ProgressBar to use tqdm.auto.tqdm() to initialize the bar when not using ray_tqdm.

https://github.com/ray-project/ray/blob/master/python/ray/data/_internal/progress_bar.py#L68

Versions / Dependencies

ray master

Reproduction script

Run the following in a Jupyter notebook:

import ray
import time

def fn(batch):
    time.sleep(10)
    return batch

ds = ray.data.range(10).repartition(10)
ds.map_batches(fn).take_all()

Issue Severity

None

@scottjlee scottjlee added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) P1 Issue that should be fixed within a few weeks data Ray Data-related issues and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Apr 26, 2024
@jonfritz
Copy link

jonfritz commented May 3, 2024

This fix would be awesome! It would be nice to see the progress bar complete - it's much easier than needing to check the completion of a cell in the left corner.

bsowell added a commit to aryn-ai/sycamore that referenced this issue Jun 19, 2024
Currently the Ray progress bar doesn't update correctly due to this
issue: ray-project/ray#44983. Until that is
fixed, we disable the progress bar by default. You can explicitly
enable by passing enable_progress_bars=True in the sycamore.init function.
@scottjlee scottjlee assigned scottjlee and unassigned c21 Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't data Ray Data-related issues P1 Issue that should be fixed within a few weeks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants