-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up runtest.py #967
Comments
At a quick glance `runtest.py` doesn't seem to only re-run tests that are
affected.
One suggestion: consider (incrementally) adopting https://bazel.build/. It
achieves the above, runs tests/builds in parallel, supports a variety of
languages, and is used by Google :)
…On Tue, Sep 12, 2017 at 10:53 AM Robert Nishihara ***@***.***> wrote:
The test suite in runtest.py takes way too long. We should speed this up.
Or alternatively we should create a simpler streamlined test suite that we
tell people to use.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#967>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAkLHq39aghornMttVpQlHjcDWz34t_zks5shsUfgaJpZM4PVBjD>
.
|
A good example project where this is used is TensorFlow (C++, Python, etc).
On Tue, Sep 12, 2017 at 11:04 AM Zongheng Yang <[email protected]>
wrote:
… At a quick glance `runtest.py` doesn't seem to only re-run tests that are
affected.
One suggestion: consider (incrementally) adopting https://bazel.build/. It
achieves the above, runs tests/builds in parallel, supports a variety of
languages, and is used by Google :)
On Tue, Sep 12, 2017 at 10:53 AM Robert Nishihara <
***@***.***>
wrote:
> The test suite in runtest.py takes way too long. We should speed this up.
> Or alternatively we should create a simpler streamlined test suite that
we
> tell people to use.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#967>, or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AAkLHq39aghornMttVpQlHjcDWz34t_zks5shsUfgaJpZM4PVBjD
>
> .
>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#967 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAkLHg0f-T4lf5CvReCkduJIcIKsSAAbks5shse0gaJpZM4PVBjD>
.
|
Nice, @rshin actually did a version of this a while back at ray-project/ray-legacy#408. |
One immediate issue with using Bazel might be that Bazel now requires Java 8, and maybe it's hard to get that inside the Docker image for building wheels, although I haven't looked into that at all. |
Closing. Now that we run tests together with |
The test suite in
runtest.py
takes way too long. We should speed this up. Or alternatively we should create a simpler streamlined test suite that we tell people to use.The text was updated successfully, but these errors were encountered: