Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up runtest.py #967

Closed
robertnishihara opened this issue Sep 12, 2017 · 5 comments
Closed

Speed up runtest.py #967

robertnishihara opened this issue Sep 12, 2017 · 5 comments

Comments

@robertnishihara
Copy link
Collaborator

The test suite in runtest.py takes way too long. We should speed this up. Or alternatively we should create a simpler streamlined test suite that we tell people to use.

@concretevitamin
Copy link
Contributor

concretevitamin commented Sep 12, 2017 via email

@concretevitamin
Copy link
Contributor

concretevitamin commented Sep 12, 2017 via email

@robertnishihara
Copy link
Collaborator Author

robertnishihara commented Sep 12, 2017

Nice, @rshin actually did a version of this a while back at ray-project/ray-legacy#408.

@rshin
Copy link
Contributor

rshin commented Sep 12, 2017

One immediate issue with using Bazel might be that Bazel now requires Java 8, and maybe it's hard to get that inside the Docker image for building wheels, although I haven't looked into that at all.

@robertnishihara
Copy link
Collaborator Author

Closing. Now that we run tests together with pytest, we can see what the slowest ones are and improve them. Also #4271 will help with test speeds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants