-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add capability to exclude directories/file types from file_mounts within cluster YAML #10110
Conversation
…cker is in the cmd, we should actually run the cmd in the host system
with yamls etc Changes to support exclude list More changes to get exclude list working Modify scripts to py to support new create_or_update_cluster Enable rsync down for all nodes Clean yamls
To use, add like this to YAML (rsync exclude syntax):
|
@richardrl To run
|
try: | ||
rsync(source, target) | ||
except: | ||
print(f"Rsync failed for node {node_id} \n") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this just for debugging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea for a PR--this will be super useful to reduce the number of extraneous files being copied (especially caches and .git
files). The only thing is it would be great to try to keep this option just for the relevant commands (rsync). If you have any questions--please let me know in follow-ups :)
def run_rsync_up(self, source, target): | ||
self._set_ssh_ip_if_required() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you possibly include this as an argument to run_rsync_up
and run_rsync_down
instead of the constructors?
rsync(source, target) | ||
except: | ||
print(f"Rsync failed for node {node_id} \n") | ||
else: | ||
updater.sync_file_mounts(rsync) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specifically, can you pas in the exclude_list
into to the rsync
function and the updater.sync_file_mounts
function.
Since rsync
is just updater.rsync_down
or updater.rsync_up
, those two functions need to be modified.
Oh, can you also pull the latest master locally and then |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message. Please feel free to reopen or open a new issue if you'd still like it to be addressed. Again, you can always ask for help on our discussion forum or Ray's public slack channel. Thanks again for opening the issue! |
Why are these changes needed?
Small syntax error fixes that prevent running various functions like "ray submit" successfully and add functionality for excluding files when syncing directories to clusters.
Checks
scripts/format.sh
to lint the changes in this PR. -> No, I get this error and I don't know what it means:flake8: error: unrecognized arguments: --inline-quotes --no-avoid-escape python/ray/autoscaler/autoscaler.py python/ray/autoscaler/command_runner.py python/ray/autoscaler/commands.py python/ray/autoscaler/node_provider.py python/ray/autoscaler/updater.py python/ray/scripts/scripts.py python/ray/tune/suggest/suggestion.py python/ray/tune/syncer.py
Not sure what to run. Are there explicit instructions anywhere?