-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GCS]Fix gcs placement group manager worker dead ut #11103
Closed
clay4megtr
wants to merge
8
commits into
ray-project:master
from
alipay:fix_gcs_placement_group_manager_worker_dead_ut
Closed
[GCS]Fix gcs placement group manager worker dead ut #11103
clay4megtr
wants to merge
8
commits into
ray-project:master
from
alipay:fix_gcs_placement_group_manager_worker_dead_ut
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please update the description to explain
|
rkooo567
added
the
@author-action-required
The PR author is responsible for the next step. Remove tag to send back to the reviewer.
label
Sep 30, 2020
clay4megtr
changed the title
[gcs]Fix gcs placement group manager worker dead ut
[GCS]Fix gcs placement group manager worker dead ut
Sep 30, 2020
hi, SangBin, I have update the comment, maybe you check it? |
rkooo567
removed
the
@author-action-required
The PR author is responsible for the next step. Remove tag to send back to the reviewer.
label
Oct 1, 2020
ffbin
reviewed
Oct 8, 2020
src/ray/gcs/gcs_server/test/gcs_placement_group_manager_test.cc
Outdated
Show resolved
Hide resolved
rkooo567
reviewed
Oct 9, 2020
rkooo567
requested changes
Oct 9, 2020
ffbin
approved these changes
Oct 10, 2020
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
update the ut code to avoid ci failed.
origin ut process
updated ut process
...
5. After step 5, we need to mark no placement group is scheduling, so that first placement group will schedule in step 10, and will remove it from pending placement group queue.
...
12. In step 12, when OnPlacementGroupCreationSuccess() method invoke the reschedule method, it will schedule the second placement group request.
supplement
Except above question, this ut is also occasionally fail in our internal project, but I haven't reproduced it locally....
Related issue number
Checks
scripts/format.sh
to lint the changes in this PR.