Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump flake8 to fix the AttributeError: 'QuoteChecker' on py3.8 #11588

Closed
wants to merge 8 commits into from
Closed

Bump flake8 to fix the AttributeError: 'QuoteChecker' on py3.8 #11588

wants to merge 8 commits into from

Conversation

thomasdesr
Copy link
Contributor

@thomasdesr thomasdesr commented Oct 24, 2020 •
edited
Loading

Why are these changes needed?

Bump flake8(-quotes)? to latest in order to stop it from having a sad when it is run with more than one file as input. This mostly happens when you run ./scripts/ci/format.sh after having modified more than one file.

Related issue number

n/a

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(
    • Manually verified that things don't explode horribly on 3.8 & 3.6

@rkooo567 rkooo567 self-assigned this Oct 24, 2020
@rkooo567
Copy link
Contributor

There's a lint failure. Please fix it!

@rkooo567 rkooo567 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Oct 26, 2020
@wuisawesome
Copy link
Contributor

Looks like bumping the lint version actually changes the formatting rules 😐. I vote we just fix this and do it anyways.

@thomasdesr
Copy link
Contributor Author

Agreed, I'll clean those up in the next day or so and re-flag for review.

@thomasdesr thomasdesr force-pushed the thomas/bump-flake8-family branch 2 times, most recently from d4f14c3 to 7e23d5a Compare October 28, 2020 20:52
wuisawesome
wuisawesome reviewed Oct 28, 2020
View reviewed changes
python/ray/tune/trial.py
@@ -301,7 +301,7 @@ def __init__(self,
if trial_dirname_creator:
self.custom_dirname = trial_dirname_creator(self)
if os.path.sep in self.custom_dirname:
raise ValueError(f"Trial dirname must not contain '/'. "
raise ValueError("Trial dirname must not contain '/'. "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardliaw btw this looks like a bug (looks like it was here before the PR)

wuisawesome
wuisawesome approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@wuisawesome wuisawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, mostly just lots of boilerplate fixes

thanks for going through the effort!

@bveeramani
Copy link
Member

‼️ ACTION REQUIRED ‼️

We've switched our code formatter from YAPF to Black (see #21311).

To prevent issues with merging your code, here's what you'll need to do:

  1. Install Black
pip install -I black==21.12b0
  1. Format changed files with Black
curl -o format-changed.sh https://gist.githubusercontent.com/bveeramani/42ef0e9e387b755a8a735b084af976f2/raw/7631276790765d555c423b8db2b679fd957b984a/format-changed.sh
chmod +x ./format-changed.sh
./format-changed.sh
rm format-changed.sh
  1. Commit your changes.
git add --all
git commit -m "Format Python code with Black"
  1. Merge master into your branch.
git pull upstream master
  1. Resolve merge conflicts (if necessary).

After running these steps, you'll have the updated format.sh.

@stale
Copy link

stale bot commented Mar 6, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Mar 6, 2022
@stale
Copy link

stale bot commented Mar 27, 2022

Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message.

Please feel free to reopen or open a new issue if you'd still like it to be addressed.

Again, you can always ask for help on our discussion forum or Ray's public slack channel.

Thanks again for opening the issue!

@stale stale bot closed this Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardliaw richardliaw richardliaw left review comments

@rkooo567 rkooo567 rkooo567 approved these changes

@wuisawesome wuisawesome wuisawesome approved these changes

Assignees

@rkooo567 rkooo567

Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. stale The issue is stale. It will be closed within 7 days unless there are further conversation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thomasdesr @rkooo567 @wuisawesome @bveeramani @richardliaw