Revert "Revert "Increase the number of unique bits for actors to avoi… #12990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkooo567
approved these changes
Dec 19, 2020
…d handle collisions (ray-project#12894)" (ray-project#12988)" This reverts commit 5d987f5.
ericl
force-pushed
the
revert-revert2
branch
from
18838f3
to
4819d7e
Compare
|
Test object manager still seems to be hanging |
ericl
changed the title
ericl
commented
Dec 21, 2020
| @@ -467,12 +467,14 @@ class TestObjectManager : public TestObjectManagerBase { | |||
| } | |||
| }; | |||
|
|
|||
| /* TODO(ekl) this seems to be hanging occasionally on Linux | |||
There was a problem hiding this comment.
@stephanie-wang do you think it's ok to remove this test? It seems to be hanging with this PR sometimes for some reason.
|
The hang seems to be gone, merging. |
cathrinS
pushed a commit
to cathrinS/ray
that referenced
this pull request
Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d handle collisions (#12894)" (#12988)"
This reverts commit 5d987f5.
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.