[tune] Correctly validate nested metrics #14375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: - Nested metrics couldn't pass validation process, since the nested result was used to validate metrics After: - Flattened result is used to validate metrics
|
thanks @RaphaelCS ! cc @krfricke could you take a look? |
ghost
mentioned this pull request
6 tasks
krfricke
approved these changes
Feb 26, 2021
ghost
deleted the
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In tune,
Before:
After:
Related issue number
Closes #14374
Checks
scripts/format.shto lint the changes in this PR.