Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Destruct reply of GRPC as early as possible #14598

Closed
wants to merge 1 commit into from
Closed

[Core] Destruct reply of GRPC as early as possible #14598

wants to merge 1 commit into from

Conversation

wumuzi520
Copy link
Contributor

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

kfstorm
kfstorm reviewed Mar 11, 2021
View reviewed changes
src/ray/rpc/client_call.h
@@ -62,7 +62,9 @@ class ClientCallImpl : public ClientCall {
/// Constructor.
///
/// \param[in] callback The callback function to handle the reply.
explicit ClientCallImpl(const ClientCallback<Reply> &callback) : callback_(callback) {}
explicit ClientCallImpl(
const std::function<void(const Status &status, std::shared_ptr<Reply>)> &callback)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not update the definition of ClientCallback?

src/ray/rpc/client_call.h
@@ -81,16 +83,16 @@ class ClientCallImpl : public ClientCall {
status = return_status_;
}
if (callback_ != nullptr) {
callback_(status, reply_);
callback_(status, std::move(reply_));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving a shared_ptr seems unnecessary.

src/ray/rpc/client_call.h
auto call = std::make_shared<ClientCallImpl<Reply>>(
[this, callback](const Status &status, std::shared_ptr<Reply> reply) {
if (callback && !main_service_.stopped() && !shutdown_) {
main_service_.post([status, reply, callback] { callback(status, *reply); });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that you copied the std::shared_ptr<Reply> here. I don't know what's the optimization here.

src/ray/rpc/server_call.h
@@ -157,10 +157,11 @@ class ServerCallImpl : public ServerCall {
// We create this before handling the request so that the it can be populated by
// the completion queue in the background if a new request comes in.
factory.CreateCall();
auto reply = std::make_shared<Reply>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you document that we want the reply to be destructed once it's sent instead of being destructed on the next request arriving?

src/ray/rpc/server_call.h
@@ -219,9 +220,6 @@ class ServerCallImpl : public ServerCall {
/// The request message.
Request request_;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not optimize request as well?

@rkooo567 rkooo567 self-assigned this Mar 11, 2021
rkooo567
rkooo567 reviewed Mar 15, 2021
View reviewed changes
Copy link
Contributor

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the description?

@rkooo567 rkooo567 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Mar 23, 2021
@rkooo567 rkooo567 mentioned this pull request Apr 15, 2021
Closed
29 tasks
@rkooo567
Copy link
Contributor

Hey @wumuzi520 what's the status of this PR?

@rkooo567
Copy link
Contributor

Unassign myself as this PR seems to be abandoned

@rkooo567 rkooo567 removed their assignment Nov 23, 2021
@bveeramani
Copy link
Member

‼️ ACTION REQUIRED ‼️

We've switched our code formatter from YAPF to Black (see #21311).

To prevent issues with merging your code, here's what you'll need to do:

  1. Install Black
pip install -I black==21.12b0
  1. Format changed files with Black
curl -o format-changed.sh https://gist.githubusercontent.com/bveeramani/42ef0e9e387b755a8a735b084af976f2/raw/7631276790765d555c423b8db2b679fd957b984a/format-changed.sh
chmod +x ./format-changed.sh
./format-changed.sh
rm format-changed.sh
  1. Commit your changes.
git add --all
git commit -m "Format Python code with Black"
  1. Merge master into your branch.
git pull upstream master
  1. Resolve merge conflicts (if necessary).

After running these steps, you'll have the updated format.sh.

@kfstorm
Copy link
Member

kfstorm commented Mar 13, 2022

‼️ ACTION REQUIRED ‼️

We've updated our formatting configuration for C++ code. (see #22725)

This PR includes C++ code change. To prevent issues with merging your code, here's what you'll need to do:

  1. Merge the latest changes from upstream/master branch into your branch.
git pull upstream master
git merge upstream/master
  1. Resolve merge conflicts (if necessary).

After running these steps, you'll have the updated C++ formatting configuration.

  1. Format changed files.
scripts/format.sh
  1. Commit your changes.
git add --all
git commit -m "Format C++ code"

@stale
Copy link

stale bot commented Apr 16, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Apr 16, 2022
@stale
Copy link

stale bot commented Jul 30, 2022

Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message.

Please feel free to reopen or open a new issue if you'd still like it to be addressed.

Again, you can always ask for help on our discussion forum or Ray's public slack channel.

Thanks again for opening the issue!

@stale stale bot closed this Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkooo567 rkooo567 rkooo567 left review comments

@kfstorm kfstorm kfstorm left review comments

@raulchen raulchen Awaiting requested review from raulchen

Assignees
No one assigned
Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. stale The issue is stale. It will be closed within 7 days unless there are further conversation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wumuzi520 @rkooo567 @bveeramani @kfstorm