[RLlib] Do not deepcopy input dict for efficiency and consistency with similar methods. #15709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h similar methods.
richardliaw
reviewed
May 14, 2021
|
BTW, be sure to cc me on your PRs in the future, as it is hard to keep track of this. |
richardliaw
approved these changes
Jul 22, 2021
|
Sorry for not writing the unit test, I was very busy recently (writing my PhD thesis !) Glad to see it was merged anyway :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
flatten_dictmethod used primarily for tensorboard logging is performing deepcopy of the input dict instead of shadow copy. It seems to be unnecessary, but maybe I missed a few edge cases. It may have a significant impact in performance on real world applications (~20%).Related issue number
Closes #15699
Checks
scripts/format.shto lint the changes in this PR.