Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rllib] current learning rate update on local worker #15911

Merged
merged 8 commits into from
Jul 13, 2021
Merged

[rllib] current learning rate update on local worker #15911

merged 8 commits into from
Jul 13, 2021

Conversation

antoine-galataud
Copy link
Contributor

@antoine-galataud antoine-galataud commented May 19, 2021 •
edited by sven1977
Loading

Closes #15910. Tested with reproduction example given in issue and custom env.

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@antoine-galataud antoine-galataud changed the title Fix 15910 [rllib] current learning rate update on local worker May 19, 2021
sven1977
sven1977 approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks a lot for the fix @antoine-galataud !

@sven1977
Copy link
Contributor

@antoine-galataud
Merged with master, just waiting for all tests to pass now.

@sven1977 sven1977 merged commit 16f1011 into ray-project:master Jul 13, 2021
@antoine-galataud antoine-galataud mentioned this pull request Jul 14, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sven1977 sven1977 sven1977 approved these changes

Assignees

@sven1977 sven1977

@michaelzhiluo michaelzhiluo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[rllib] cur_lr not updated on local worker when LearningRateSchedule used on APEX DQN
3 participants
@antoine-galataud @sven1977 @michaelzhiluo