Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly support working_dir in Serve #16480

Merged
merged 3 commits into from
Jul 24, 2021
Merged

Properly support working_dir in Serve #16480

merged 3 commits into from
Jul 24, 2021

Conversation

edoakes
Copy link
Contributor

@edoakes edoakes commented Jun 16, 2021 •
edited
Loading

Why are these changes needed?

Related issue number

Closes #16318

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@edoakes
Copy link
Contributor Author

edoakes commented Jun 16, 2021

This is blocked on #16481

@simon-mo simon-mo mentioned this pull request Jul 22, 2021
Merged
6 tasks
@simon-mo simon-mo changed the title [WIP] Properly support working_dir in Serve Properly support working_dir in Serve Jul 23, 2021
@simon-mo simon-mo merged commit 2142aba into ray-project:master Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-mo simon-mo simon-mo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[runtime env] Make Serve fully support runtime_env
2 participants
@edoakes @simon-mo