[rllib] CV2 to Skimage change #16841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardliaw
reviewed
Jul 2, 2021
|
Adding skimage as a dependecy for rllib sounds good! |
|
@richardliaw where do I add it? Is it just |
|
Generics seem great! Hmm so if cv2 is not a requirement, perhaps we dont
need skimage as a requirement, just raise a good error message?
…On Wed, Jul 7, 2021 at 8:09 AM Vince Jankovics ***@***.***> wrote:
@richardliaw <https://github.com/richardliaw> where do I add it? Is it
just python/requirements_rllib.txt?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16841 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABCRZZNC4OUSOOLQZD2M4WDTWRU4JANCNFSM47WNJVCA>
.
|
richardliaw
reviewed
Jul 9, 2021
|
@richardliaw thanks, I added the debug message and type hints, let me know if that's not how you wanted them. |
|
Awesome. Sven is back now so I’ll let him merge. Ping me in 2 days if you
don’t hear back!
…On Mon, Jul 12, 2021 at 7:14 AM Vince Jankovics ***@***.***> wrote:
@richardliaw <https://github.com/richardliaw> thanks, I added the debug
message and type hints, let me know if that's not how you wanted them.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#16841 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABCRZZJ2OA43WE4V74SBW23TXL2CPANCNFSM47WNJVCA>
.
|
|
Re-running tests after updating from master. ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This removes the OpenCV dependency, which makes installation simpler.
Should I also include skimage as a dependency for the RLlib build?
Related issue number
This is based on the discussion here.
Checks
scripts/format.shto lint the changes in this PR.