Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Client] Except TypeError when Deserializing #17035

Merged
merged 2 commits into from
Jul 16, 2021
Merged

[Client] Except TypeError when Deserializing #17035

merged 2 commits into from
Jul 16, 2021

Conversation

ijrsvt
Copy link
Contributor

@ijrsvt ijrsvt commented Jul 13, 2021

Why are these changes needed?

A malformed exception can also cause a TypeError

Related issue number

Helps debug #16743

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

amogkam
amogkam approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijrsvt ijrsvt merged commit 23d4391 into ray-project:master Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amogkam amogkam amogkam approved these changes

Assignees

@matthewdeng matthewdeng

@amogkam amogkam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ijrsvt @amogkam @matthewdeng