Network interface error condition tests and missing security group bug fix #17207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…issing security group bug fix.
pdames
force-pushed
the
network-interface-tests
branch
from
738a761
to
a8de5ce
Compare
wuisawesome
approved these changes
Jul 20, 2021
There was a problem hiding this comment.
Looks pretty logical and test cases are always welcome. I'm going to go ahead and merge this, but @DmitriGekhtman FYI
|
Tests relevant to autoscaler are green. merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adds basic error condition unit tests for #14080, fixes a bug where an error is not raised if only a subset of network interfaces for a given node type don't specify security groups, and corrects a minor error message typo (missing space).
Related issue number
N/A
Checks
scripts/format.shto lint the changes in this PR.