Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tune] Add test for flatten_dict. #17241

Merged
merged 2 commits into from
Jul 22, 2021

Conversation

xwjiang2010
Copy link
Contributor

@xwjiang2010 xwjiang2010 commented Jul 21, 2021

Why are these changes needed?

Add unit test for flatten_dict.

Related issue number

Closes #15699

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@xwjiang2010 xwjiang2010 changed the title [tune] Add test for flatten_dict. [tune] Add test for flattern_dict. Jul 21, 2021
@xwjiang2010 xwjiang2010 changed the title [tune] Add test for flattern_dict. [tune] Add test for flatten_dict. Jul 21, 2021
Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@richardliaw richardliaw merged commit f3a31a3 into ray-project:master Jul 22, 2021
@xwjiang2010 xwjiang2010 deleted the onboarding branch July 22, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tune] Significant impact on performance of unnecessary copy TBXLogger.on_result (~20%)
3 participants