Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi & single deployment large scale test #17310

Merged
merged 15 commits into from
Jul 27, 2021

Conversation

jiaodong
Copy link
Member

@jiaodong jiaodong commented Jul 24, 2021

Summary

  • Added multi deployment test with 1k replica and 100 deployments
  • Multi deployment will randomly pick next endpoint from all 100 existing ones, include self, and stop at depth of 5
  • Warmup at each endpoint / deployment has its own ray remote task and executed in parallel
  • Each node has its own HTTP Proxy as well as wrk job simulating load balanced traffic
  • Metrics are parsed and aggregated as one, and shows per thread/node/cluster level
  • A bunch of refactoring

Test plan

1 deployment, 1k replicas, 10 cpu per node, 100 connections per wrk:

https://beta.anyscale.com/o/anyscale-internal/projects/prj_UgMsAz5Rqk2iuvHmyrBH3S4E/clusters/ses_TQztbsGqe6rauG23JdaJihgi?command-history-section=command_history

100 deployments, 1k replicas, 10 cpu per node, 100 connections per wrk:

https://beta.anyscale.com/o/anyscale-internal/projects/prj_UgMsAz5Rqk2iuvHmyrBH3S4E/clusters/ses_89uwNQunRpcDsiBZ73y8BRYi

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@edoakes
Copy link
Contributor

edoakes commented Jul 26, 2021

@jiaodong please fix merge conflicts from the PR I just merged!

@edoakes edoakes added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jul 26, 2021
@jiaodong jiaodong force-pushed the multi_deployment_large_scale_test branch from 3cdec94 to 846290e Compare July 26, 2021 20:47
Copy link
Contributor

@edoakes edoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. From the results it looks like we have some work to do in tuning & understanding the perf.

@edoakes edoakes merged commit 9eb1bcd into ray-project:master Jul 27, 2021
stephanie-wang pushed a commit to stephanie-wang/ray that referenced this pull request Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants