-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi & single deployment large scale test #17310
Merged
edoakes
merged 15 commits into
ray-project:master
from
jiaodong:multi_deployment_large_scale_test
Jul 27, 2021
Merged
Multi & single deployment large scale test #17310
edoakes
merged 15 commits into
ray-project:master
from
jiaodong:multi_deployment_large_scale_test
Jul 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jiaodong please fix merge conflicts from the PR I just merged! |
edoakes
added
the
@author-action-required
The PR author is responsible for the next step. Remove tag to send back to the reviewer.
label
Jul 26, 2021
rebase
jiaodong
force-pushed
the
multi_deployment_large_scale_test
branch
from
July 26, 2021 20:47
3cdec94
to
846290e
Compare
edoakes
approved these changes
Jul 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. From the results it looks like we have some work to do in tuning & understanding the perf.
stephanie-wang
pushed a commit
to stephanie-wang/ray
that referenced
this pull request
Jul 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@author-action-required
The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
1 deployment, 1k replicas, 10 cpu per node, 100 connections per wrk:
https://beta.anyscale.com/o/anyscale-internal/projects/prj_UgMsAz5Rqk2iuvHmyrBH3S4E/clusters/ses_TQztbsGqe6rauG23JdaJihgi?command-history-section=command_history
100 deployments, 1k replicas, 10 cpu per node, 100 connections per wrk:
https://beta.anyscale.com/o/anyscale-internal/projects/prj_UgMsAz5Rqk2iuvHmyrBH3S4E/clusters/ses_89uwNQunRpcDsiBZ73y8BRYi
Checks
scripts/format.sh
to lint the changes in this PR.