Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tune] Add define-by-run support to OptunaSearcher #17464

Merged
merged 16 commits into from
Aug 3, 2021

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented Jul 30, 2021

Why are these changes needed?

Define-by-run is one of the main features of Optuna, allowing for pythonic definition of search spaces and conditional parameters. This PR adds support to functions that would normally be used in Optuna, allowing users to switch to Tune-powered Optuna without the need to convert their search spaces.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Yard1 Yard1 requested a review from krfricke July 30, 2021 15:23
@Yard1 Yard1 changed the title [WIP][tune] Add define-by-run support to OptunaSearcher [tune] Add define-by-run support to OptunaSearcher Jul 30, 2021
@Yard1 Yard1 marked this pull request as ready for review July 30, 2021 15:23
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, some minor nits

python/ray/tune/tests/test_sample.py Show resolved Hide resolved
python/ray/tune/tests/test_sample.py Show resolved Hide resolved
@krfricke krfricke merged commit c40555c into ray-project:master Aug 3, 2021
@Yard1 Yard1 deleted the optuna_define_by_run branch August 3, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants