Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyTorch Lightning Updates #17876

Merged
merged 23 commits into from
Aug 28, 2021
Merged

PyTorch Lightning Updates #17876

merged 23 commits into from
Aug 28, 2021

Conversation

amogkam
Copy link
Contributor

@amogkam amogkam commented Aug 16, 2021

Various updates for PyTorch Lightning + Ray

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@amogkam amogkam changed the title Ptl updates PyTorch Lightning Updates Aug 16, 2021
@krfricke
Copy link
Contributor

Can you fix the conflicts and lint? Happy to review afterwards

@amogkam
Copy link
Contributor Author

amogkam commented Aug 19, 2021

Blocked on ray-project/ray_lightning#78

@amogkam
Copy link
Contributor Author

amogkam commented Aug 20, 2021

OK this is ready for review again

@amogkam
Copy link
Contributor Author

amogkam commented Aug 26, 2021

Hey can you guys take a look at this please

Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, please merge when tests pass

@richardliaw richardliaw merged commit 3b77840 into ray-project:master Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue on page /tune/tutorials/tune-pytorch-lightning.html
3 participants