Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core][ObjectRef] Change default to not record call stack during ObjectRef creation #18078

Merged
merged 8 commits into from
Aug 27, 2021
Merged

[Core][ObjectRef] Change default to not record call stack during ObjectRef creation #18078

merged 8 commits into from
Aug 27, 2021

Commits on Aug 25, 2021

  1. Disable recording call site for ObjectRef creations

    @mwtian
    mwtian committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    a3a1bd9 View commit details
    Browse the repository at this point in the history

  2. benchmark

    @mwtian
    mwtian committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    635bd1c View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2021

  1. Add instruction to enable callsite in ======== Object references stat… 

    …us: 2021-08-25 17:10:41.494492 ========

Grouping by node address...        Sorting by object size...        Display allentries per group...

--- Summary for node address: 192.168.0.234 ---
Mem Used by Objects  Local References  Pinned        Pending Tasks  Captured in Objects  Actor Handles
0.0 B                1, (-1.0 B)       0, (0.0 B)    0, (0.0 B)     0, (0.0 B)           0, (0.0 B)

--- Object references for node address: 192.168.0.234 ---
IP Address | PID | Type | Call Site | Size | Reference Type | Object Ref

192.168.0.234 | 27804 | Driver |           | ?    | LOCAL_REFERENCE | a67dc375e60ddd1affffffffffffffffffffffff0100000001000000

To record callsite information for each ObjectRef created, set env variable RAY_record_ref_creation_sites=1

--- Aggregate object store stats across all nodes ---
Plasma memory usage 0 MiB, 0 objects, 0.0% full, 0.0% needed message
    @mwtian
    mwtian committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    5b83ca4 View commit details
    Browse the repository at this point in the history

  2. fix

    @mwtian
    mwtian committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    c87839a View commit details
    Browse the repository at this point in the history

  3. Update ray memory output 

    Co-authored-by: Eric Liang <[email protected]>
    @mwtian @ericl
    mwtian and ericl authored Aug 26, 2021
    Configuration menu
    Copy the full SHA
    dfe6bfe View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2021

  1. fix test_memstat

    @mwtian
    mwtian committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    669cb9c View commit details
    Browse the repository at this point in the history

  2. fix all tests in

    @mwtian
    mwtian committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    5f5e301 View commit details
    Browse the repository at this point in the history

  3. fix #2

    @mwtian
    mwtian committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    8fd7b77 View commit details
    Browse the repository at this point in the history