-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core][Spill manager refactor 2] Implements ISpillWorkerPool with IOWorkerPool #18375
Conversation
std::function<void(ray::Status, std::vector<std::string>)> spill_callback) override; | ||
|
||
void StartDeleteWorker(std::vector<std::string> files_to_delete, | ||
std::function<void(ray::Status)> delete_callback) override; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need CancelXXX
?
IOSpillWorkerPool(instrumented_io_context &worker_pooler_executor, | ||
IOWorkerPoolInterface &io_worker_pool); | ||
|
||
void StartSpillWorker( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty much same comment as previous PR. We only seem to have Start*, but not like Dispatch* APIs. Is StartSpillWorker
if we need to start workers, and otherwise it will only dispatch work to it?
|
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message. Please feel free to reopen or open a new issue if you'd still like it to be addressed. Again, you can always ask for help on our discussion forum or Ray's public slack channel. Thanks again for opening the issue! |
Implements ISpillWorkerPoll interface using IOWorkerPool. Since IOWorkerPool is not thread safe we post it onto the IOWorkerPool io_context to execute.
TODO