Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Provide information about resource deadlocks, early stopping in Tune docs #18947

Merged
merged 5 commits into from
Oct 1, 2021

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented Sep 28, 2021

Why are these changes needed?

Provides a section in the FAQ regarding deadlocks caused by not enough resources being allocated to trials, and extends the "Which search algorithm/scheduler should I choose?" section

Related issue number

Related to #18808, modin-project/modin#3479 (comment)

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Yard1
Copy link
Member Author

Yard1 commented Sep 28, 2021

CC @devin-petersohn @jmakov

@jmakov
Copy link
Contributor

jmakov commented Sep 28, 2021

Much clearer also for newcomers. Thanks!

Copy link
Member

@devin-petersohn devin-petersohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Yard1 !

doc/source/tune/_tutorials/_faq.inc Outdated Show resolved Hide resolved
doc/source/tune/_tutorials/_faq.inc Outdated Show resolved Hide resolved
@krfricke krfricke merged commit cc3199b into ray-project:master Oct 1, 2021
@Yard1 Yard1 deleted the tune_docs_extra_resources branch October 1, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants