Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Datasets] Handle empty datasets properly in most Dataset transformations. #18983

Merged
merged 1 commit into from
Sep 30, 2021
Merged

[Datasets] Handle empty datasets properly in most Dataset transformations. #18983

merged 1 commit into from
Sep 30, 2021

Conversation

clarkzinzow
Copy link
Contributor

Explicitly handles empty datasets for more transformations, treating the operation as a no-op.

Related issue number

Closes #18972

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

scv119
scv119 approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@scv119 scv119 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you!

@clarkzinzow clarkzinzow added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Sep 30, 2021
@ericl ericl merged commit 73a6cda into ray-project:master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scv119 scv119 scv119 approved these changes

@ericl ericl ericl approved these changes

Assignees

@ericl ericl

@scv119 scv119

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug/data] filter() on empty dataset raises ValueError
3 participants
@clarkzinzow @ericl @scv119