[TaskPool] Cancel all transformation tasks when one task fails or when SIGINT is received #18991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericl
reviewed
Sep 30, 2021
ericl
added
the
@author-action-required
…n SIGINT is received.
clarkzinzow
force-pushed
the
datasets/fix/transformation-error-behavior
branch
from
883e0ec
to
2b6c765
Compare
clarkzinzow
added
tests-ok
ericl
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a transformation task fails or when
KeyboardInterruptis raised (i.e. SIGINT is received), we cancel all other transformation tasks and reraise the exception. Note that this only changes the behavior of the task compute model; the actor compute model is unchanged.TODOs
Related issue number
Closes #18171
Checks
scripts/format.shto lint the changes in this PR.