[tune] Use queue to display JupyterNotebookReporter updates in Ray client #19137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogkam
approved these changes
Oct 6, 2021
python/ray/tune/tune.py
Outdated
| remote_future = remote_run.remote(_remote=False, **remote_run_kwargs) | ||
|
|
||
| # ray.wait(...)[1] returns futures that are not ready, yet | ||
| while ray.wait([remote_future], timeout=1)[1]: |
There was a problem hiding this comment.
do we want to make this timeout=0?
There was a problem hiding this comment.
This will then iterate through the loop too fast as we're not blocking anywhere. I decreased the timeout to 0.2 though to allow a more responsive experience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Jupyter notebook HTML updates need access to the main process stdout - however, this is not available in remote tune.run calls (e.g. via Ray client). This PR introduces an execution queue that can be utilized to display Jupyter notebook updates.
Related issue number
Closes #16016
Checks
scripts/format.shto lint the changes in this PR.