[tune] Optional forcible trial cleanup, return default autofilled metrics even if Trainable doesn't report at least once #19144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xwjiang2010
reviewed
Oct 6, 2021
xwjiang2010
reviewed
Oct 6, 2021
xwjiang2010
reviewed
Oct 6, 2021
|
Thanks for picking this up. Can you add a screenshot of what the autofilled metrics would look like? |
xwjiang2010
reviewed
Oct 7, 2021
| @@ -123,15 +130,27 @@ def cleanup(self, partial: bool = True): | |||
| If partial=False, all futures are expected to return. If a future | |||
| does not return within the timeout period, the cleanup terminates. | |||
| """ | |||
| # At this point, self._cleanup_map holds the last references | |||
There was a problem hiding this comment.
@krfricke Do you know why we return_pg before calling trainable.stop()?
If pg is gone, it doesn't make sense to stop the actor anymore?
Also if we can rely on GC to always clean up remote actor, why do we bother with self._cleanup_map anyways?
There was a problem hiding this comment.
Also if we can rely on GC to always clean up remote actor, why do we bother with self._cleanup_map anyways?
We want to have a way to keep a reference for the actor during graceful termination so that the cleanup method may finish
|
LGTM. Just some questions for my own understanding. |
xwjiang2010
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR adds two features:
TUNE_FORCE_TRIAL_CLEANUP.Related issue number
Closes #18745
Checks
scripts/format.shto lint the changes in this PR.