Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serve] Remove log poll client from replicas #19145

Conversation

edoakes
Copy link
Contributor

@edoakes edoakes commented Oct 6, 2021

Why are these changes needed?

In general, broadcasting changes to the replicas via the LongPollClient is hard to reason about (it circumvents our versioning semantics as there's no rolling update). Ideally we would only be using the LongPollClient to broadcast replica membership and nothing else.

Related issue number

Closes #19145

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a user-visible change because this option was not able to be parametrized anyways.

I actually think we should not bake shutdown time to constants, rather, just let the replica take backend config in the init args.
It should be parameterized option because it is useful adjust this parameter properly (not through monkey patching constants) for various testing, release testings, and fault injection testing. Additionally, this will have impact for how long can a replica scale down (relevant to autoscaling). We just need to do little work to make sure it's configurable (and remove experimental now we finalized the mechanism).

@edoakes
Copy link
Contributor Author

edoakes commented Oct 6, 2021

@simon-mo fair point, let me refactor and make it a hidden field in .options for now

@edoakes edoakes changed the title [serve] Remove graceful shutdown periods from BackendConfig, allowing us to remove log poll client in replicas [serve] Remove log poll client from replicas Oct 6, 2021
@edoakes edoakes requested a review from simon-mo October 6, 2021 22:19
@edoakes
Copy link
Contributor Author

edoakes commented Oct 6, 2021

@simon-mo updated

Copy link
Contributor

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You might need to fix Java compilation failures.

@edoakes edoakes merged commit 9cf19b6 into ray-project:master Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants