Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve] Use regular dict for handle caching #19162

Merged
merged 9 commits into from
Oct 20, 2021

Conversation

simon-mo
Copy link
Contributor

@simon-mo simon-mo commented Oct 6, 2021

Closes #18980

Note that the long term solution should be using one long poller
per process instead of per handle.

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Closes ray-project#18980

Note that the long term solution should be using one long poller
per process instead of per handle.
@edoakes edoakes added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Oct 6, 2021
@simon-mo simon-mo merged commit 59eef65 into ray-project:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[serve] serve.get_deployment from within a deployment fails after 1k calls
2 participants