[RLlib] TF2/eager memory leak fixes. #19198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krfricke
approved these changes
Oct 8, 2021
Comment on lines
+759
to
+763
| if len(pre_batches) > 1: | ||
| other_batches = pre_batches.copy() | ||
| del other_batches[agent_id] | ||
| else: | ||
| other_batches = {} |
There was a problem hiding this comment.
Not even sure this was necessary, but our new memory leak finder was nit-picky here. I'll leave it in and add a TODO comment to remove this once confirmed it's not causing an actual leak.
gjoliver
approved these changes
Oct 8, 2021
|
there seems to be a relevant test failure though. hey @sven1977, are all these diffs really needed? since this is a cherry-pick commit, we may want to limit the diff to only the ones that contribute to that 1GB/2M step memory leak? |
2 tasks
gjoliver
reviewed
Oct 8, 2021
| @@ -92,7 +92,7 @@ def test_ppo_compilation_and_schedule_mixins(self): | |||
| config["model"]["lstm_cell_size"] = 10 | |||
| config["model"]["max_seq_len"] = 20 | |||
| # Use default-native keras models whenever possible. | |||
| config["model"]["_use_default_native_models"] = True | |||
| # config["model"]["_use_default_native_models"] = True | |||
There was a problem hiding this comment.
is this line necessary or just debugging?
sven1977
added
the
tests-ok
sven1977
changed the title
gjoliver
pushed a commit
that referenced
this pull request
Oct 8, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TF2/eager: Memory leak fix.
Why are these changes needed?
Issue #19233
Related issue number
Closes #19233
Checks
scripts/format.shto lint the changes in this PR.