Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve] Make long poll wait for non-existent keys #19205

Merged
merged 2 commits into from
Oct 8, 2021

Conversation

simon-mo
Copy link
Contributor

@simon-mo simon-mo commented Oct 7, 2021

Why are these changes needed?

This makes long poll host wait for non-existent keys instead of immediately erroring and trigger client to immediately retries. The original issue happened because a deployment takes a long time to startup, but http proxy already created the handles for those deployments and tries to pull the REPLICA_HANDLES for the deployments. The handles key doesn't exist as deployment pending, so long poll client keep retries and cause a lot of exceptions (key not found) in controller and it being retried every 50ms or so.

Related issue number

Closes #19201

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@simon-mo simon-mo changed the title Serve/long poll wait [Serve] Make long poll wait for non-existent keys Oct 7, 2021
@simon-mo simon-mo merged commit 46e8034 into ray-project:master Oct 8, 2021
@simon-mo simon-mo mentioned this pull request Oct 18, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Serve] Spammy error every 50ms when deployment not ready
2 participants