Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tune] Remove queue_trials. #19472

Merged
merged 4 commits into from
Oct 22, 2021
Merged

[Tune] Remove queue_trials. #19472

merged 4 commits into from
Oct 22, 2021

Conversation

xwjiang2010
Copy link
Contributor

@xwjiang2010 xwjiang2010 commented Oct 18, 2021 •
edited
Loading

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@xwjiang2010
Copy link
Contributor Author

@krfricke Do you know if I need to run weekly pbt test manually? My concern is not sure how pbt may be affected by this change.

@xwjiang2010 xwjiang2010 changed the title [Tune] WIP - remove queue_trials. [Tune] Remove queue_trials. Oct 18, 2021
krfricke
krfricke requested changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! We should just make sure to properly deprecate the queue_trials argument from run() and run_experiments() so users with existing scripts are guided towards adjusting their code to make it run again (most likely just removing that argument).

python/ray/tune/tune.py Show resolved Hide resolved
release/long_running_distributed_tests/workloads/pytorch_pbt_failure.py Outdated Show resolved Hide resolved
python/ray/tune/tune.py Show resolved Hide resolved
krfricke
krfricke requested changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's raise an error and give a wordy explanation so people know how to adjust their script and what behavior to expect.

python/ray/tune/tune.py Outdated Show resolved Hide resolved
python/ray/tune/tune.py Outdated Show resolved Hide resolved
python/ray/tune/tune.py Outdated
Comment on lines 660 to 661
_remote: bool = None,
queue_trials: bool = None):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_remote: bool = None,
queue_trials: bool = None):
queue_trials: bool = None,
_remote: bool = None):

python/ray/tune/tune.py Outdated Show resolved Hide resolved
krfricke
krfricke approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@krfricke krfricke merged commit a632cb4 into ray-project:master Oct 22, 2021
@xwjiang2010 xwjiang2010 deleted the tune-loop branch July 26, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krfricke krfricke krfricke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xwjiang2010 @krfricke