[Datasets] Unrevert Arrow table copy method change. #19534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…contain tensor columns. (ray-project#19494)" (ray-project#19517)" This reverts commit a6f9c93.
ericl
approved these changes
Oct 20, 2021
|
LGTM if it passes the linear dataset test |
ericl
reviewed
Oct 20, 2021
ericl
reviewed
Oct 20, 2021
| assert len(chunk) == b - a | ||
| bufs = chunk.buffers() | ||
| print(len(bufs)) | ||
| assert bufs[1].address != og_bufs[1].address |
…ation, guaranteeing single-copy.
|
@ericl I updated this to use chunk concatenation to copy instead of the NumPy roundtrip, this should be guaranteed to be single-copy and should prevent any data coercions from happening. Please take another look! |
Co-authored-by: Eric Liang <[email protected]>
clarkzinzow
changed the title
clarkzinzow
added
the
tests-ok
|
@ericl Datasets tests and Ray Train examples are passing, MacOS failures appear to be unrelated, so this is gtg in terms of CI. |
matthewdeng
pushed a commit
that referenced
this pull request
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unreverts the reversion of #19494. This PR also changes the Arrow table copy method to a per-column copy via chunk concatenation, which
Opening the PR to let the failing example run in CI since I wasn't able to reproduce the failure locally.
Related issue number
Closes #19476
Checks
scripts/format.shto lint the changes in this PR.